Skip to content

[5.9.1] Enable macros for Windows in 5.9.1 #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[5.9.1] Enable macros for Windows in 5.9.1 #4832

merged 1 commit into from
Oct 3, 2023

Conversation

@bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Sep 29, 2023

Cherry-picks 6cbe5e0.

Don't assume that the temporary directory doesn't include symlinks.

@tristanlabelle @bnbarham
Enable macros for Windows in 5.9.1
084c1e8 
Cherry-picks 6cbe5e0.

-----

Don't assume that the temporary directory doesn't include symlinks.
@bnbarham bnbarham mentioned this pull request Sep 29, 2023
Merged
@bnbarham bnbarham changed the base branch from release/5.9.0 to release/5.9.1 September 29, 2023 21:40
This was referenced Sep 29, 2023
Merged
Merged
Merged
@bnbarham
Copy link
Contributor Author

bnbarham commented Sep 29, 2023

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Oct 2, 2023

@swift-ci please test

@bnbarham
Copy link
Contributor Author

bnbarham commented Oct 2, 2023

@swift-ci please test macOS platform

@bnbarham
Copy link
Contributor Author

bnbarham commented Oct 2, 2023

Whole bunch of SwiftXCTestFunctionalTests failures on macOS:

Failed Tests (24):
  SwiftXCTestFunctionalTests :: ArgumentParser/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Expectations/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Handler/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Misuse/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Notifications/Expectations/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Notifications/Handler/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Predicates/Expectations/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Predicates/Handler/main.swift
  SwiftXCTestFunctionalTests :: Asynchronous/Use/main.swift
  SwiftXCTestFunctionalTests :: EqualityWithAccuracy/main.swift
  SwiftXCTestFunctionalTests :: ErrorHandling/main.swift
  SwiftXCTestFunctionalTests :: FailingTestSuite/main.swift
  SwiftXCTestFunctionalTests :: FailureMessagesTestCase/main.swift
  SwiftXCTestFunctionalTests :: ListTests/main.swift
  SwiftXCTestFunctionalTests :: Observation/All/main.swift
  SwiftXCTestFunctionalTests :: Observation/MultipleObservers/main.swift
  SwiftXCTestFunctionalTests :: Observation/Selected/main.swift
  SwiftXCTestFunctionalTests :: Performance/Misuse/main.swift
  SwiftXCTestFunctionalTests :: Performance/main.swift
  SwiftXCTestFunctionalTests :: SelectedTest/main.swift
  SwiftXCTestFunctionalTests :: SingleFailingTestCase/main.swift
  SwiftXCTestFunctionalTests :: SkippingTestCase/main.swift
  SwiftXCTestFunctionalTests :: TestCaseLifecycle/Misuse/main.swift
  SwiftXCTestFunctionalTests :: TestCaseLifecycle/main.swift

Which is weird, since this is literally just test expectation changes in 3 tests not listed there 😅

@DougGregor DougGregor merged commit 3ed5d7e into swiftlang:release/5.9.1 Oct 3, 2023
@bnbarham bnbarham deleted the 591-macros branch October 3, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd approved these changes

@DougGregor DougGregor DougGregor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bnbarham @compnerd @DougGregor @tristanlabelle