[6.2] fix build failures for WASI #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows building the `cmark-gfm` target for both `wasm32-unknown-wasi` and `wasm32-unknown-wasip1-threads`. The other targets are not tested.
The differences between two target triples:
- `wasm32-unknown-wasi`
- C
- can import `unistd.h`
- has `__wasi__`
- does not have `__unix__`
- **does not have `_REENTRANT`**
- **does not have `_POSIX_THREADS`**
- **does not support pthreads API at all**
- Swift
- can use `#if os(WASI)`
- SwiftPM
- `BuildSettingsCondition`'s `Platform` is `.wasi`
- `wasm32-unknown-wasip1-threads`
- C
- can import `unistd.h`
- has `__wasi__`
- does not have `__unix__`
- **has `_REENTRANT` (defined in wasi-libc)**
- **has `_POSIX_THREADS` (defined in wasi-libc)**
- **supports a subset of pthreads API**
- Swift
- can use `#if os(WASI)`
- SwiftPM
- `BuildSettingsCondition`'s `Platform` is `.wasi`
This reverts commit 6f64876.
This reverts commit aef4761.
QuietMisdreavus
approved these changes
Oct 29, 2025
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
It looks like this is already being used by the toolchain builds of Swift-DocC (since the toolchain is using gfm directly for release/6.2 instead of this branch) so that plus the fact that there shouldn't be any code change for non-WASI platforms means that this should be safe to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #75, merged as cbd8eae
Explanation: This change allows building the
cmark-gfmtarget for bothwasm32-unknown-wasiandwasm32-unknown-wasip1-threads.Scope: Limited to WASI support.
Risk: Low due to changes not impacting other platforms.
Testing: Added in
swift-formatrepo, which has a transitive dependency onswift-cmark.Issue: rdar://163652438
Reviewer: @QuietMisdreavus