Simplify hashing example setup, update readme #7
Conversation
necessary for publishing the swift-java artifacts with the least amount of annoyance
|
This follows up @davelester's request to make the setup as simple and consistent as possible. We don't actually need JDK 25 except when releasing swift-java which itself only has one module which needs it, but to make things as simple as possible for now, let's just keep recommending the latest so folks don't have to flip-flop between multiple JDKs, especially if they're new to Java. Please double check this @madsodgaard. I took these steps from "nothing installed" and these are pretty fool-proof AFAICS, so should be safe to link to from a blog. |
Co-authored-by: finagolfin <[email protected]>
|
Alright, merge when you're ready. |
Added installation instructions for sdkman and Java setup.
|
Just added a pull request for this because I don't have direct write access: #8 |
Update README with sdkman installation instructions
|
This is just waiting for Mishal to merge, I think everybody else is good. |
|
@justice-adams-apple is verifying the instructions. |
| Before you can build and run this project, you need to have the following installed: | ||
|
|
||
| * **Java Development Kit (JDK)**: We recommend using JDK 21. Ensure the `JAVA_HOME` environment variable is set to your JDK installation path. | ||
| * **Java Development Kit (JDK)**: This example requires the use of JDK 25. This is only necessary to locally publish the swift-java dependencies, and will not be required in the future. To simplify the build steps, we recommend installing JDK 25 and following all the steps below using the same JDK. Ensure the `JAVA_HOME` environment variable is set to your JDK installation path. |
There was a problem hiding this comment.
I found that I needed to have JAVA_HOME set at a system level (via zprofile) before launching android studio for the swiftpm invocation of swift-java to work. I assume this is expected since the JNI headers aren't found in the JBR installation at /Applications/Android Studio.app/Contents/jbr/Contents/Home ?
Other than that the instructions worked with JDK 25 👍
There was a problem hiding this comment.
Let's follow up on this with future PR. Thanks!
This simplifies the setup a little bit
Near future simplifications: None of this JDK requiring would matter once we can release swift-java artifacts, but this is still an ongoing process -- hopefully soon we'll be able to, and then we can remove all this jdk installing and local publishing from this guide.