Change logging to use OSLog
#859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
2 times, most recently
from
5587282 to
ef8b839
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
from
ef8b839 to
14d92ec
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
from
14d92ec to
a2ddde0
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
from
a2ddde0 to
dd7c078
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
hamishknight
approved these changes
Oct 11, 2023
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
from
dd7c078 to
174c426
Compare
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
from
174c426 to
ca388db
Compare
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
from
ca388db to
537c975
Compare
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Linux |
OSLog is the suggesting logging solution on Apple platforms and we should be using it there, taking advantage of the different log levels and privacy masking. Switch sourcekit-lsp to use OSLog on Apple platforms and implement a logger that is API-compatible with OSLog for all uses in sourcekit-lsp and which can be used on non-Darwin platforms. The goal of this commit is to introduce the new logging API. There are still improvements about what we log and we can display more privacy-insensitive information after masking. Those changes will be in follow-up commits.
ahoppen
force-pushed
the
ahoppen/migrate-to-oslog
branch
from
537c975 to
f960d7e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
compnerd
added a commit
to compnerd/swift-build
that referenced
this pull request
Oct 15, 2023
SouceKit-LSP now depends on SwiftCrypto (see swiftlang/sourcekit-lsp#859). This should repair the build on main.
compnerd
added a commit
to compnerd/swift-build
that referenced
this pull request
Oct 15, 2023
SourceKit-LSP now has a dependency on Crypto. Adjust the build rules accordingly.
compnerd
added a commit
to compnerd/swift-build
that referenced
this pull request
Oct 15, 2023
SourceKit-LSP now has a dependency on Crypto. Adjust the build rules accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSLog is the suggesting logging solution on Apple platforms and we should be using it there, taking advantage of the different log levels and privacy masking.
Switch sourcekit-lsp to use OSLog on Apple platforms and implement a logger that is API-compatible with OSLog for all uses in sourcekit-lsp and which can be used on non-Darwin platforms.
The goal of this commit is to introduce the new logging API. There are still improvements about what we log and we can display more privacy-insensitive information after masking. Those changes will be in follow-up commits.