Generalize educational notes documentation test to not require the ".…md" suffix #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
approved these changes
Apr 15, 2025
Comment on lines
+382
to
+386
| let filename = diag.codeDescription?.href.fileURL?.lastPathComponent | ||
| XCTAssertNotNil(filename) | ||
| if let filename { | ||
| XCTAssert(filename.starts(with: "property-wrapper-requirements")) | ||
| } |
There was a problem hiding this comment.
One suggestion to make the test a little nicer.
Suggested change
| let filename = diag.codeDescription?.href.fileURL?.lastPathComponent | |
| XCTAssertNotNil(filename) | |
| if let filename { | |
| XCTAssert(filename.starts(with: "property-wrapper-requirements")) | |
| } | |
| let filename = try XCTUnwrap(diag.codeDescription?.href.fileURL?.lastPathComponent) | |
| XCTAssert(filename.starts(with: "property-wrapper-requirements")) |
There was a problem hiding this comment.
Sure, it's here: #2113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See swiftlang/swift#80814 for more context