Skip to content

Remove SourceKitLSPServer.openGeneratedInterface #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

Remove SourceKitLSPServer.openGeneratedInterface #1907

merged 1 commit into from
Jan 4, 2025

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 3, 2025

The method was never called.

@ahoppen
Copy link
Member Author

ahoppen commented Jan 3, 2025

@swift-ci Please test

@ahoppen ahoppen merged commit 991b893 into swiftlang:main Jan 4, 2025
3 checks passed
@ahoppen ahoppen deleted the remove-unused-method branch January 4, 2025 08:23
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this pull request Jan 8, 2025
@ahoppen
Revert "Merge pull request swiftlang#1907 from ahoppen/remove-unused-…
2122cd3 
…method"

This reverts commit 991b893, reversing
changes made to c214a5f.
@ahoppen ahoppen mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham