[Coro] [async] Disable inlining in async coroutine splitting #8130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Please test with the following PR: @swift-ci test |
The call to the inlining utility does not update the call graph. Leading to assertion failures when calling the utility to update the call graph. Instead rely on an inline pass to run after coro splitting and use alwaysinline annotations. github.com/swiftlang/swift/issues/68708 rdar://115905828
aschwaighofer
force-pushed
the
coro_noinline
branch
from
3aabf58 to
4a51a10
Compare
Author
|
Please test with the following PR: @swift-ci test |
Author
|
@swift-ci test windows |
Author
|
Please test with the following PR: @swift-ci test windows |
1 similar comment
Author
|
Please test with the following PR: @swift-ci test windows |
Author
|
@swift-ci test |
Author
|
Please test with the following PR: @swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to the inlining utility does not update the call graph. Leading to assertion failures when calling the utility to update the call graph.
Instead rely on an inline pass to run after coro splitting and use alwaysinline annotations.
github.com/swiftlang/swift/issues/68708