[lldb] Make generic expr eval work with multiple toplevel generic params #5793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
| @@ -91,6 +91,9 @@ class SwiftASTManipulatorBase { | |||
| swift::VarDecl::Introducer GetVarIntroducer() const; | |||
| bool GetIsCaptureList() const; | |||
| bool IsMetadataPointer() const { return m_name.str().startswith("$τ"); } | |||
| bool IsOutermostMetadataPointer() const { | |||
There was a problem hiding this comment.
Isn't depth 0 the innermost one?
There was a problem hiding this comment.
Just double-checked, 0 is the outermost depth. From the Swift generics book: "The depth identifies a specific generic declaration, starting from zero for the top- level generic declaration and incrementing for each nested generic declaration."
lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionSourceCode.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/ExpressionParser/Swift/SwiftUserExpression.cpp
Outdated
Show resolved
Hide resolved
Before this patch, generic expression evaluation would only work for a single toplevel generic parameter. This patch expands its capabilities to allow for multiple generic parameters.
augusto2112
force-pushed
the
bind-many-self-params-0
branch
from
adf90df to
09e6631
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, generic expression evaluation would only work for a single toplevel generic parameter. This patch expands its capabilities to allow for multiple generic parameters.