[lldb] Pass likely module names to reflection parsing machinery #4927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test macOS |
|
@swift-ci test macOS |
kastiglione
reviewed
Jul 6, 2022
| @@ -623,8 +623,25 @@ GetObjectFileFormat(llvm::Triple::ObjectFormatType obj_format_type) { | |||
| return obj_file_format; | |||
| } | |||
|
|
|||
| static llvm::SmallVector<llvm::StringRef, 1> | |||
There was a problem hiding this comment.
does it work to say SmallVector<llvm::StringRef>?
There was a problem hiding this comment.
It does, I chose 1 because I think in the vast majority of cases we'll only have one name per image.
| virtual bool readELF(swift::remote::RemoteAddress ImageStart, | ||
| llvm::Optional<llvm::sys::MemoryBlock> FileBuffer) = 0; | ||
| find_section, | ||
| llvm::SmallVector<llvm::StringRef, 1> likely_module_names = {}) = 0; |
There was a problem hiding this comment.
There was a problem hiding this comment.
As stated above, I chose 1 because I think in the vast majority of cases we'll only have one name per image, which I think is a reasonable assumption. Perhaps I should've passed SmallVectorImpl to the addImage functions, but I just merged the swift side of this patch 😕
|
@swift-ci macOS |
|
@swift-ci please test macOS |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://87889973