Fix a bug in Launch when using an async debugger & remote platform. #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't setting the listener back to the unhijacked one in this case, so that a continue after the stop fails. It thinks the process is still running. Also add tests for this behavior. Differential Revision: https://reviews.llvm.org/D112747 (cherry picked from commit e655769)
|
@swift-ci please test |
jimingham
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
This looks correct, we we missing a place where we needed to restore the process events, and that leads to a stall where we can no longer continue. The patch is right. Also, this went through review when submitted to llvm.org and has been in place for months now. We don't have any local differences that would require changes.
|
Unrelated failure @swift-ci please test macos |
|
|
@swift-ci please test macos |
JDevlieghere
deleted the
🍒/austria/e655769c4a7b5a17b17eace3bd160b3b015b75ed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't setting the listener back to the unhijacked one in this
case, so that a continue after the stop fails. It thinks the process
is still running. Also add tests for this behavior.
Differential Revision: https://reviews.llvm.org/D112747
(cherry picked from commit e655769)