🍒 [Clang][LLDB] Refactor trap reason demangling out of LLDB and into Clang (#165996) #11752
+122
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ang (llvm#165996) This patch refactors the trap reason demangling logic in `lldb_private::VerboseTrapFrameRecognizer::RecognizeFrame` into a new public function `clang::CodeGen::DemangleTrapReasonInDebugInfo`. There are two reasons for doing this: 1. In a future patch the logic for demangling needs to be used somewhere else in LLDB and thus the logic needs refactoring to avoid duplicating code. 2. The logic for demangling shouldn't really be in LLDB anyway because it's a Clang implementation detail and thus the logic really belongs inside Clang, not LLDB. Unit tests have been added for the new function that demonstrate how to use the new API. The function names recognized by VerboseTrapFrameRecognizer are identical to before. However, this patch isn't NFC because: * The `lldbTarget` library now links against `clangCodeGen` which it didn't previously. * The LLDB logging output is a little different now. The previous code tried to log failures for an invalid regex pattern and for the `Regex::match` API not returning the correct number of matches. These failure conditions are unreachable via unit testing so they have been made assertions failures inside the `DemangleTrapReasonInDebugInfo` implementation instead of trying to log them in LLDB. rdar://163230807 (cherry picked from commit 3ebed51)
delcypher
added
the
clang:bounds-safety
|
@swift-ci test |
|
@swift-ci test llvm |
|
@swift-ci please test Windows platform |
kavon
deleted the
dliew/demangle-trap-reason-refactor-cherry-pick-stable-21.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the trap reason demangling logic in
lldb_private::VerboseTrapFrameRecognizer::RecognizeFrameinto a new public functionclang::CodeGen::DemangleTrapReasonInDebugInfo.There are two reasons for doing this:
Unit tests have been added for the new function that demonstrate how to use the new API.
The function names recognized by VerboseTrapFrameRecognizer are identical to before. However, this patch isn't NFC because:
lldbTargetlibrary now links againstclangCodeGenwhich it didn't previously.Regex::matchAPI not returning the correct number of matches. These failure conditions are unreachable via unit testing so they have been made assertions failures inside theDemangleTrapReasonInDebugInfoimplementation instead of trying to log them in LLDB.rdar://163230807
(cherry picked from commit 3ebed51)