[-Wunsafe-buffer-usage] Check safe assignment patterns #11680
Merged
+325
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykstefanski
requested review from
delcypher,
hnrklssn,
rapidsna and
ziqingluo-90
patrykstefanski
added
the
clang:bounds-safety
hnrklssn
reviewed
Nov 1, 2025
hnrklssn
reviewed
Nov 1, 2025
clang/test/SemaCXX/warn-unsafe-buffer-usage-count-attributed-pointer-assignment.cpp
Outdated
Show resolved
Hide resolved
hnrklssn
reviewed
Nov 1, 2025
clang/test/SemaCXX/warn-unsafe-buffer-usage-count-attributed-pointer-assignment.cpp
Show resolved
Hide resolved
hnrklssn
approved these changes
Nov 1, 2025
patrykstefanski
force-pushed
the
eng/pstefanski/PR-161608493
branch
2 times, most recently
from
a73715e to
77d721c
Compare
ziqingluo-90
approved these changes
Nov 5, 2025
| QualType Ty = VD->getType(); | ||
| const auto *CAT = Ty->getAs<CountAttributedType>(); | ||
| if (!CAT && Ty->isPointerType()) | ||
| CAT = Ty->getPointeeType()->getAs<CountAttributedType>(); |
There was a problem hiding this comment.
Do we have tests covering this case?
There was a problem hiding this comment.
Yes, those cases happen when we have a dereference on LHS (*ptr = ). We have tests like this:
void good_inout_span(int *__counted_by(*count) *p, size_t *count, std::span<int> sp) {
*p = sp.data();
*count = sp.size();
}|
|
||
| const BinaryOperator *Assign = Group.Assignments[I]; | ||
|
|
||
| // TODO: Move this logic to isCountAttributedPointerArgumentSafeImpl. |
There was a problem hiding this comment.
yeah, the parameters of isCountAttributedPointerArgumentSafeImpl aren't the most intuitive. Technically, we do not need the caller to pass CountArg because the count expression with DependentValues already contain that information.
There was a problem hiding this comment.
I will take care of this TODO in my refactoring patch.
|
@swift-ci test llvm |
Check safe assignment patterns. This uses the infrastructure that is already available for count-attributed arguments, and checks for each assigned pointer in the group that the RHS has enough elements. rdar://161608493
patrykstefanski
force-pushed
the
eng/pstefanski/PR-161608493
branch
from
77d721c to
12d943e
Compare
|
@swift-ci test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check safe assignment patterns. This uses the infrastructure that is already available for count-attributed arguments, and checks for each assigned pointer in the group that the RHS has enough elements.
rdar://161608493