Skip to content

Enable strict concurrency #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

Enable strict concurrency #47

merged 1 commit into from
Dec 3, 2024

Conversation

czechboy0
Copy link
Contributor

Motivation:

Catch potential data races at build time.

Modifications:

  • Enabled strict concurrency checking in the Package.swift and removed it from the CI flags.

Result:

Fewer potential data races can sneak in.

Test Plan

Ran tests locally, did not see any concurrency warnings or errors.

@czechboy0 czechboy0 added the semver/none No version bump required. label Dec 3, 2024
@czechboy0 czechboy0 merged commit 350450f into swift-server:main Dec 3, 2024
23 of 24 checks passed
@czechboy0 czechboy0 deleted the hd-strict-concurrency branch December 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czechboy0 @glbrntt