Skip to content

Conversation

fabianfett
Copy link
Member

We should check for API breaking changes in CI, to ensure we don't accidentally break API going forwards.

Motivation:

  • We should check for API breaking changes in CI, to ensure we don't accidentally break API going forwards.

Modifications:

  • Add a script that checks for breaking changes (copy and pasted from NIO).

Result:

  • We ensure we don't accidentally break API after 1.0

Open tasks:

@tomerd we need to add another CI that runs the API checking script.

@fabianfett fabianfett added the kind/enhancement Improvements to existing feature. label Apr 15, 2022
@fabianfett fabianfett requested a review from tomerd April 15, 2022 11:04
@tomerd
Copy link
Contributor

tomerd commented Apr 15, 2022

thanks @fabianfett, should we add a docker compose task that runs this, or do we need to do that at the CI server level?

nm, added one

@fabianfett
Copy link
Member Author

@tomerd I tried to see what we do in AHC. However I did not find a special docker-compose task for it. So I assume it is activated in the CI server.

@tomerd
Copy link
Contributor

tomerd commented Apr 15, 2022

@swift-server-bot test this please

1 similar comment
@tomerd
Copy link
Contributor

tomerd commented Apr 15, 2022

@swift-server-bot test this please

@tomerd tomerd merged commit f6c7c5a into swift-server:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants