Skip to content

Fix crash when writablity becomes false and races against finishing the http request #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2024
Merged

Fix crash when writablity becomes false and races against finishing the http request #768

merged 3 commits into from
Sep 3, 2024

Conversation

fabianfett
Copy link
Member

Motivation

If the channel's writability changed to false just before we finished a request, we currently run into a precondition.

Changes

  • Remove the precondition and handle the case appropiatly

Result

A crash less.

@fabianfett fabianfett requested a review from weissi September 3, 2024 11:18
weissi
weissi approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@fabianfett fabianfett merged commit 1120541 into swift-server:main Sep 3, 2024
6 of 7 checks passed
@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Sep 3, 2024
@Lukasa Lukasa mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @weissi @FranzBusch