Correctly shutdown HTTP2ConnectionPool if connection creation fails.
#647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eateNewConnection`
dnadoba
force-pushed
the
dn-switch-over-state-in-failed-to-create-new-connection
branch
from
933bb94 to
2cf3d0e
Compare
fabianfett
approved these changes
Nov 9, 2022
dnadoba
deleted the
dn-switch-over-state-in-failed-to-create-new-connection
branch
Lukasa
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previous code assumed that we were always in the running state. We therefore never transition from the shuttingDown to the shutDown state if the last connection in the pool fails.
Modifications
Result
HTTPClient is correctly shut down if HTTP2 connections establishment fails while shut down is in progress.
Resolves #638