Skip to content

Reduce use of HTTPClient.Configuration in the Connection objects #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fabianfett
Copy link
Member

Motivation

If we introduce a new 2/3 tier design, we have a new configuration object next to HTTPClient.Configuration. To prepare the way, we should reduce the areas in which we rely on HTTPClient.Configuration directly.

Changes

  • Depend on only the decompression settings in HTTP1Connection and HTTP2Connection
  • Remove dead/unused code

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Oct 7, 2022
@fabianfett fabianfett requested review from Lukasa and dnadoba October 7, 2022 14:58
@Lukasa Lukasa enabled auto-merge (squash) October 7, 2022 15:00
@Lukasa Lukasa merged commit af5966f into swift-server:main Oct 7, 2022
@dnadoba dnadoba deleted the ff-reduce-use-of-HTTPClient.Configuration branch October 7, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants