Skip to content

Add Hashable conformance to HTTPClient.Configuration.Proxy #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2022
Merged

Add Hashable conformance to HTTPClient.Configuration.Proxy #634

merged 1 commit into from
Oct 7, 2022

Conversation

fabianfett
Copy link
Member

Motivation

If we want to make progress on a 2/3-tier design, we need to take proxy settings into account for pool keying.

Changes

  • Make HTTPClient.Configuration.Proxy hashable

@fabianfett fabianfett added the 🆕 semver/minor Adds new public API. label Oct 7, 2022
@fabianfett fabianfett requested review from Lukasa and dnadoba October 7, 2022 14:44
@Lukasa Lukasa merged commit 64ff430 into swift-server:main Oct 7, 2022
@fabianfett fabianfett deleted the ff-add-hashable-coformance-to-proxy branch October 7, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@dnadoba dnadoba Awaiting requested review from dnadoba

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @Lukasa