Crash fix: HTTP2 can handle requests are cancelled #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
approved these changes
Feb 10, 2022
| XCTAssertNoThrow(request = try HTTPClient.Request(url: "https://localhost:\(bin.port)")) | ||
|
|
||
| // just to establish an existing connection | ||
| XCTAssertNoThrow(try client.execute(request: XCTUnwrap(request)).wait()) |
There was a problem hiding this comment.
oh, nice use of XCTUnwrap inside a throwable auto closure!
| @@ -193,11 +193,15 @@ final class HTTP2ClientRequestHandler: ChannelDuplexHandler { | |||
| case .forwardResponseBodyParts(let parts): | |||
| self.request!.receiveResponseBodyParts(parts) | |||
|
|
|||
| case .failRequest(let error, let finalAction): | |||
| case .failRequest(let error, _): | |||
There was a problem hiding this comment.
Do we still use finalAction elsewhere or can we remove it from the enum?
There was a problem hiding this comment.
We use it in the HTTP1ConnectionStateMachine.
There was a problem hiding this comment.
This is the reason for the comment starting in line 200.
glbrntt
approved these changes
Feb 10, 2022
Sources/AsyncHTTPClient/ConnectionPool/HTTP2/HTTP2ClientRequestHandler.swift
Outdated
Show resolved
Hide resolved
Sources/AsyncHTTPClient/ConnectionPool/HTTPRequestStateMachine.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: George Barnett <[email protected]>
|
@swift-server-bot test this please |
|
5.6 and nightly failing because of Sendable requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a already cancelled request is scheduled on an existing HTTP/2 connection we currently run into a crash. This only happens if the request is scheduled on the same EventLoop as the HTTP/2 connection.
Changes
HTTPRequestStateMachineresilient to failures before request start.Result