Skip to content

Add async shutdown method to HTTPClient #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2022
Merged

Add async shutdown method to HTTPClient #551

merged 3 commits into from
Feb 7, 2022

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Feb 4, 2022

Allows to shutdown a HTTPClient in an async context without blocking or using the callback version of shutdown.

@dnadoba dnadoba added the 🆕 semver/minor Adds new public API. label Feb 4, 2022
@dnadoba dnadoba requested a review from fabianfett February 4, 2022 16:29
Lukasa
Lukasa approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace, LGTM.

@dnadoba dnadoba merged commit f3830d1 into swift-server:main Feb 7, 2022
@dnadoba dnadoba deleted the dn-async-shutdown branch February 7, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnadoba @Lukasa @fabianfett