Skip to content

Print invalid state, if hitting precondition #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

fabianfett
Copy link
Member

If we hit a precondition because of an invalid state, we should print the state to make debugging easier.

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Jan 24, 2022
Copy link
Collaborator

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianfett fabianfett force-pushed the ff-print-invalid-state branch from 20c6399 to 72ee85e Compare January 24, 2022 09:51
@fabianfett
Copy link
Member Author

CI failing on nightly-5.6 and nightly-main because of Sendable requirements.

@fabianfett fabianfett merged commit 2497a68 into swift-server:main Jan 24, 2022
@fabianfett fabianfett deleted the ff-print-invalid-state branch January 24, 2022 11:26
fabianfett added a commit to fabianfett/async-http-client that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants