Skip to content

Add HTTP/2 stream integration tests #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fabianfett
Copy link
Member

@fabianfett fabianfett commented Nov 30, 2021

Motivation

We should have http/2 integration tests for requests where we don't know the request size upfront.

Changes

  • Depend on swift-nio-http2 1.19.0
  • Adds 2 integration tests.

Result

Better test coverage for http/2.

@fabianfett fabianfett requested a review from dnadoba November 30, 2021 10:36
@fabianfett fabianfett force-pushed the ff-h2-stream-integration-tests branch from 2787693 to 1156087 Compare November 30, 2021 10:36
@fabianfett fabianfett force-pushed the ff-h2-stream-integration-tests branch from 1156087 to 8885489 Compare December 1, 2021 07:44
@fabianfett fabianfett added semver/none No version bump required. 🔨 semver/patch No public API change. and removed semver/none No version bump required. labels Dec 1, 2021
@fabianfett fabianfett marked this pull request as ready for review December 1, 2021 07:46
@fabianfett
Copy link
Member Author

fabianfett commented Dec 1, 2021

Flaky test?

[377/378] Testing AsyncHTTPClientTests.HTTPClientTests/testConnectionPoolSizeConfigValueIsRespected
Build timed out (after 10 minutes). Marking the build as failed.

@swift-server-bot test this please

@fabianfett
Copy link
Member Author

@swift-server-bot test this please

@fabianfett fabianfett merged commit 70826d0 into swift-server:main Dec 1, 2021
@fabianfett fabianfett deleted the ff-h2-stream-integration-tests branch December 1, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants