Skip to content

[Tests] Remove XCTAssertNoThrow that wraps XCTAssertEqual #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2021
Merged

[Tests] Remove XCTAssertNoThrow that wraps XCTAssertEqual #500

merged 2 commits into from
Nov 26, 2021

Conversation

fabianfett
Copy link
Member

Motivation

In HTTPClient we often wrap XCTAssertEqual in a XCTAssertNoThrow. This isn't actually needed (anymore).

Changes

  • Remove unused XCTAssertNoThrows

@fabianfett fabianfett requested a review from dnadoba November 26, 2021 09:38
@fabianfett fabianfett added the semver/none No version bump required. label Nov 26, 2021
dnadoba
dnadoba approved these changes Nov 26, 2021
View reviewed changes
Copy link
Collaborator

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup!

@dnadoba dnadoba merged commit 83c2625 into swift-server:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@dnadoba dnadoba dnadoba approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @Lukasa @dnadoba