Fix bug in migration from HTTP1 to HTTP2 and back to HTTP1 #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
approved these changes
Nov 20, 2021
Comment on lines
601
to
607
| return lhs.close == rhs.close && | ||
| lhs.starting.elementsEqual(rhs.starting, by: { | ||
| $0.0 == $1.0 && $0.1 === $1.1 | ||
| }) && | ||
| lhs.backingOff.elementsEqual(rhs.backingOff, by: { | ||
| $0.0 == $1.0 && $0.1 === $1.1 | ||
| }) |
Member
There was a problem hiding this comment.
NIT: Interesting auto formatting...
fabianfett
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to update the
overflowIndexduring migration from HTTP1 to HTTP2. The added test case would crash without the fix.