Task refactoring #47
Merged
Task refactoring #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Users may want to optimize memory usage when executing request with big bodies, same as streaming download Modifications: Added ChunkProvider typealias in HTTPHandler.swift Added new Body enum case - stream in HTTPHandler.swift Extracted body processing in HTTPHandler.swift to a separate method Added .stream enum processing in HTTPHandler.swift Added upload streaming test to SwiftNIOHTTPTests.swift Result: HTTPClient library now provides methods to stream Request body
| @@ -272,8 +276,16 @@ public extension HTTPClient { | |||
| } | |||
| } | |||
|
|
|||
| public func succeed(_ value: Response) { | |||
There was a problem hiding this comment.
Does this need to be public? Should a user of the library be able to succeed/fail the task themselves?
There was a problem hiding this comment.
good point, this shouldn't be public, thanks!
tanner0101
reviewed
Jun 20, 2019
tanner0101
approved these changes
Jun 21, 2019
ianpartridge
approved these changes
Jun 24, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having promise and a future inside Handler and Task, I propose to hide the promise inside the Task and drop future from it