Skip to content

[HTTP2] Forward HTTP/2 events to StateMachine #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

[HTTP2] Forward HTTP/2 events to StateMachine #466

merged 1 commit into from
Nov 4, 2021

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Nov 3, 2021

Motivations

We want to start writing HTTP/2 integration tests

Changes

  • HTTP2Connection now forwards the initial maxConccurentStreams settings
  • HTTP2Connection events are forwarded to HTTPConnectionPool.StateMachine
  • HTTP/2 events are logged

@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Nov 3, 2021
@dnadoba dnadoba force-pushed the dn-http2-forward-events branch from 5e5e1e7 to 65e347c Compare November 3, 2021 15:07
fabianfett
fabianfett approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@fabianfett fabianfett requested a review from Lukasa November 3, 2021 15:37
@dnadoba dnadoba merged commit 7d1ed4c into swift-server:main Nov 4, 2021
@dnadoba dnadoba deleted the dn-http2-forward-events branch November 4, 2021 11:01
@fabianfett fabianfett added this to the HTTP/2 support milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
HTTP/2 support
Development

Successfully merging this pull request may close these issues.
3 participants
@dnadoba @Lukasa @fabianfett