[HTTP2] Improve performance for backoff timer #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Nov 3, 2021
fabianfett
reviewed
Nov 3, 2021
| /// - Returns: | ||
| /// `onAnyEventLoop`: true if at least one connection is starting or active regardless of the event loop. | ||
| /// `onSpecifiedEventLoop`: true if at least one connection is starting or active for the given `eventLoop`. | ||
| func hasAnyStartingOrActiveConnectionAnd( |
fabianfett
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #462 to improve performance as proposed in #462 (comment)
This also fixes a bug where we would not create a new connection after a backoff timer fires if we have other connections backing off. (in
hasAnyStartingOrActiveConnectionAndwe also returned true if a connection is in the backing off state)