Improve HTTPClient tests #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
commented
Sep 13, 2021
| } | ||
| func testDeadline() { | ||
| XCTAssertThrowsError(try self.defaultClient.get(url: self.defaultHTTPBinURLPrefix + "wait", deadline: .now() + .milliseconds(150)).wait()) { | ||
| XCTAssertEqual($0 as? HTTPClientError, .readTimeout) |
There was a problem hiding this comment.
Getting a readTimeout error on a deadline is weird. This will be actually fixed with the new implementation
Lukasa
approved these changes
Sep 13, 2021
fabianfett
force-pushed
the
ff-better-http-client-tests
branch
from
b041fe3 to
10fff8d
Compare
fabianfett
force-pushed
the
ff-better-http-client-tests
branch
from
10fff8d to
18c0a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some tests that make it hard to see the reason for a test failure. Since
HTTPClientErroris equatable, let's useXCTAssertEqualModifications
XCTAssertEqualto compareHTTPClientErrorsResult