add another expires date format #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Nov 11, 2020
There was a problem hiding this comment.
RFC 2616 was obsoleted a while back. The relevant citation is now RFC 7231 § 7.1.1.1, and that provides us a normative MUST:
A recipient that parses a timestamp value in an HTTP header field
MUST accept all three HTTP-date formats.
We are currently only accepting two: we should update this patch to tolerate all three.
artemredkin
force-pushed
the
update_expires_date_parsing
branch
from
7dbc774 to
011d744
Compare
|
Good catch, fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
rfc2616#section-3.3.1date format parsing.Motivation:
The https://tools.ietf.org/html/rfc2616#section-3.3.1 specifies the Sunday, 06-Nov-94 08:49:37 GMT as a valid date format. We need to support that.
Modifications:
Updated cookie parsing to support additional date format.
Result:
Closes #314