update ci setup #193
Merged
update ci setup #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaky test? |
motivation: 5.2 adoption, prepare for 5.3 changes: * use 5.2 docker-compose setup * add 5.3 docker-compose setup (placeholder) * update format
|
@swift-server-bot test this please |
artemredkin
reviewed
Apr 4, 2020
| test: | ||
| image: swift-metrics:18.04-5.2 | ||
| environment: [] | ||
| #- SANITIZER_ARG=--sanitize=thread |
There was a problem hiding this comment.
why is sanitizer disabled?
There was a problem hiding this comment.
tsan issue on 18.04, we have it enabled on 16.04 which is what the ci uses
artemredkin
reviewed
Apr 4, 2020
|
@swift-server-bot test this please |
artemredkin
approved these changes
Apr 4, 2020
|
test mentioned ^^ is failing, i believe unrelated to this change |
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: 5.2 adoption, prepare for 5.3
changes: