Skip to content

Task.Logger should be accessible to the delegate #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weissi opened this issue Jul 6, 2021 · 0 comments · Fixed by #587
Closed

Task.Logger should be accessible to the delegate #389

weissi opened this issue Jul 6, 2021 · 0 comments · Fixed by #587
Labels
good first issue Good for newcomers kind/enhancement Improvements to existing feature.

Comments

@weissi
Copy link
Contributor

weissi commented Jul 6, 2021

The delegate should be able to log through task.logger which is even available but internal and not public.
@Lukasa Lukasa added kind/enhancement Improvements to existing feature. good first issue Good for newcomers labels Jul 6, 2021
felixschlegel added a commit to felixschlegel/async-http-client that referenced this issue May 24, 2022
@felixschlegel
Make Task.logger accessible to delegate implementations outside of Pa…
60cd101 
…ckage

Motivation:

This change was proposed in issue
[swift-server#389](swift-server#389).
Users writing their own `HttpClientResponseDelegate` implementation
might want to emit log messages to the `task`'s `logger`.

Modifications:

Changed the access level of `Task`'s `logger` property from `internal`
to `public`.

Result:

Users can access the `logger` property of a `Task` outside of the
`async-http-client`.
@felixschlegel felixschlegel mentioned this issue May 24, 2022
Merged
felixschlegel added a commit to felixschlegel/async-http-client that referenced this issue May 24, 2022
@felixschlegel
Make Task.logger accessible to delegate implementations outside of Pa…
e277c8d 
…ckage

Motivation:

This change was proposed in issue
[swift-server#389](swift-server#389).
Users writing their own `HttpClientResponseDelegate` implementation
might want to emit log messages to the `task`'s `logger`.

Modifications:

Changed the access level of `Task`'s `logger` property from `internal`
to `public`.

Result:

Users can access the `logger` property of a `Task` outside of the
`async-http-client`.
felixschlegel added a commit to felixschlegel/async-http-client that referenced this issue May 24, 2022
@felixschlegel
Make Task.logger accessible to delegate implementations outside of Pa…
1e901b9 
…ckage

Motivation:

This change was proposed in issue
[swift-server#389](swift-server#389).
Users writing their own `HttpClientResponseDelegate` implementation
might want to emit log messages to the `task`'s `logger`.

Modifications:

Changed the access level of `Task`'s `logger` property from `internal`
to `public`.

Result:

Users can access the `logger` property of a `Task` outside of the
`async-http-client`.
@FranzBusch FranzBusch linked a pull request Jul 20, 2022 that will close this issue
Make Task.logger accessible to delegate implementations outside of Package #587
Merged
felixschlegel added a commit to felixschlegel/async-http-client that referenced this issue Jan 22, 2023
@felixschlegel
Make Task.logger accessible to delegate implementations outside of Pa…
72a12ec 
…ckage

Motivation:

This change was proposed in issue
[swift-server#389](swift-server#389).
Users writing their own `HttpClientResponseDelegate` implementation
might want to emit log messages to the `task`'s `logger`.

Modifications:

Changed the access level of `Task`'s `logger` property from `internal`
to `public`.

Result:

Users can access the `logger` property of a `Task` outside of the
`async-http-client`.
dnadoba pushed a commit that referenced this issue Jan 22, 2023
@felixschlegel
Make Task.logger accessible to delegate implementations outside of Pa…
817d9aa 
…ckage (#587)

Motivation:

This change was proposed in issue
[#389](#389).
Users writing their own `HttpClientResponseDelegate` implementation
might want to emit log messages to the `task`'s `logger`.

Modifications:

Changed the access level of `Task`'s `logger` property from `internal`
to `public`.

Result:

Users can access the `logger` property of a `Task` outside of the
`async-http-client`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
No milestone
2 participants
@weissi @Lukasa