fix: missing clicked in mappingcomponent #370
Merged
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to handle model selection events from the aircraft models view. When a user clicks on a model in the aircraft models table view, the selected model is now automatically populated into the model string completer.
- Added
onModelSelectedInViewslot that handles model selection from the aircraft models view - Connected the
clickedsignal fromtvp_AircraftModelsto the new slot
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gui/components/mappingcomponent.h | Declared the new onModelSelectedInView slot |
| src/gui/components/mappingcomponent.cpp | Implemented the slot and connected it to the view's clicked signal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
oktal3700
approved these changes
Nov 5, 2025
ltoenning
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in swiftgui where models could not be assigned from the list in the model matcher.