Enable clang-tidy in CI #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements clang-tidy integration in the CI pipeline to enforce modern C++ coding standards. The changes focus on modernizing C++ code style and removing redundant constructs throughout the codebase.
- Replace empty destructors with
= default - Remove redundant
virtualkeywords on override functions - Use modern C++ initialization and construction patterns
- Apply auto type deduction where appropriate
Reviewed Changes
Copilot reviewed 300 out of 1122 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui/components/*.h/cpp | Modernized destructors, removed virtual on overrides, applied auto deduction |
| src/core/context/*.h/cpp | Removed redundant virtual keywords, modernized constructors and destructors |
| src/core/db/*.h/cpp | Applied modern C++ patterns, simplified return statements |
| src/core/fsd/*.h/cpp | Replaced empty constructors/destructors with default, used brace initialization |
| src/core/data/*.h/cpp | Modernized constructors and property handling |
| src/core/*.h/cpp | Applied clang-tidy modernization suggestions throughout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344