refactor: Fix cppcoreguidelines-init-variables warnings

Author: ltoenning

.clang-tidy

@@ -45,6 +45,7 @@ Checks: >
   readability-use-std-min-max,
   readability-use-anyofallof,
   readability-redundant-member-init,
+  cppcoreguidelines-init-variables,
 
 CheckOptions:
   - key: readability-identifier-naming.ClassCase

src/core/afv/audio/input.cpp

@@ -159,7 +159,7 @@ namespace swift::core::afv::audio
             m_maxSampleInput = qMax(qAbs(sampleInput), m_maxSampleInput);
         }
 
-        int length;
+        int length {};
         const QByteArray encodedBuffer = m_encoder.encode(samples, samples.size(), &length);
         m_opusBytesEncoded += length;
 

src/core/context/contextapplicationproxy.h

@@ -96,7 +96,7 @@ namespace swift::core
         protected:
             //! Constructor
             CContextApplicationProxy(CCoreFacadeConfig::ContextMode mode, CCoreFacade *runtime)
-                : IContextApplication(mode, runtime), m_dBusInterface(nullptr)
+                : IContextApplication(mode, runtime)
             {}
 
             //! DBus version constructor

src/core/context/contextownaircraftimpl.cpp

@@ -284,7 +284,7 @@ namespace swift::core::context
         {
             CLogMessage(this, CLogCategories::contextSlot()).debug() << Q_FUNC_INFO << com1 << com2 << transponder;
         }
-        bool changed;
+        bool changed {};
         {
             QWriteLocker l(&m_lockAircraft);
             changed = m_ownAircraft.hasChangedCockpitData(com1, com2, transponder);
@@ -301,7 +301,7 @@ namespace swift::core::context
         {
             CLogMessage(this, CLogCategories::contextSlot()).debug() << Q_FUNC_INFO << transponderMode;
         }
-        bool changed;
+        bool changed {};
         {
             QWriteLocker l(&m_lockAircraft);
             changed = m_ownAircraft.setTransponderMode(transponderMode);

src/core/db/databaseutils.cpp

@@ -425,7 +425,7 @@ namespace swift::core::db
                 const int contentIndex = content.indexOf(':', cl);
                 if (contentIndex < cl) break; // should not happen, malformed
                 const QString ls = content.mid(cl, contentIndex - cl); // content length
-                bool ok;
+                bool ok {};
                 const qint32 size = ls.toInt(&ok);
                 if (!ok) break; // malformed size
                 if (size < 1) break;

src/core/db/databasewriter.cpp

@@ -172,7 +172,7 @@ namespace swift::core::db
             CAircraftModelList modelsPublished;
             CAircraftModelList modelsSkipped;
             CStatusMessageList msgs;
-            bool directWrite;
+            bool directWrite {};
             const bool sendingSuccessful =
                 parseSwiftPublishResponse(responseData, modelsPublished, modelsSkipped, msgs, directWrite);
             const int c = CDatabaseUtils::fillInMissingAircraftAndLiveryEntities(modelsPublished);

src/core/fsd/interimpilotdataupdate.cpp

@@ -17,7 +17,7 @@ namespace swift::core::fsd
 
     QStringList InterimPilotDataUpdate::toTokens() const
     {
-        std::uint32_t pbh;
+        std::uint32_t pbh {};
         packPBH(m_pitch, m_bank, m_heading, m_onGround, pbh);
 
         auto tokens = QStringList {};

src/core/fsd/pilotdataupdate.cpp

@@ -24,7 +24,7 @@ namespace swift::core::fsd
 
     QStringList PilotDataUpdate::toTokens() const
     {
-        std::uint32_t pbh;
+        std::uint32_t pbh {};
         packPBH(m_pitch, m_bank, m_heading, m_onGround, pbh);
 
         QStringList tokens;

src/core/fsd/visualpilotdataperiodic.cpp

@@ -27,7 +27,7 @@ namespace swift::core::fsd
 
     QStringList VisualPilotDataPeriodic::toTokens() const
     {
-        std::uint32_t pbh;
+        std::uint32_t pbh {};
         packPBH(m_pitch, m_bank, m_heading, false /*! \todo check if needed? */, pbh);
 
         QStringList tokens;

src/core/fsd/visualpilotdatastopped.cpp

@@ -23,7 +23,7 @@ namespace swift::core::fsd
 
     QStringList VisualPilotDataStopped::toTokens() const
     {
-        std::uint32_t pbh;
+        std::uint32_t pbh {};
         packPBH(m_pitch, m_bank, m_heading, false /*! \todo check if needed? */, pbh);
 
         QStringList tokens;