refactor: Fix readability-redundant-member-init warning

ltoenning · ltoenning · commit 00abb9d2cf12 · 2025-10-30T23:28:08.000+01:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -44,6 +44,7 @@ Checks: >
   modernize-use-using,
   readability-use-std-min-max,
   readability-use-anyofallof,
+  readability-redundant-member-init,
 
 CheckOptions:
   - key: readability-identifier-naming.ClassCase
diff --git a/src/core/fsd/addatc.cpp b/src/core/fsd/addatc.cpp
@@ -8,8 +8,6 @@
 
 namespace swift::core::fsd
 {
-    AddAtc::AddAtc() : MessageBase() {}
-
     AddAtc::AddAtc(const QString &callsign, const QString &realName, const QString &cid, const QString &password,
                    AtcRating rating, int protocolRevision)
         : MessageBase(callsign, "SERVER"), m_cid(cid), m_password(password), m_rating(rating),
diff --git a/src/core/fsd/addatc.h b/src/core/fsd/addatc.h
@@ -47,7 +47,7 @@ namespace swift::core::fsd
         QString realName() const { return m_realName; }
 
     private:
-        AddAtc();
+        AddAtc() = default;
 
         QString m_cid;
         QString m_password;
diff --git a/src/core/fsd/addpilot.h b/src/core/fsd/addpilot.h
@@ -50,7 +50,7 @@ namespace swift::core::fsd
         static QString pdu() { return "#AP"; }
 
     private:
-        AddPilot() : MessageBase() {}
+        AddPilot() = default;
 
         QString m_cid;
         QString m_password;
diff --git a/src/core/fsd/atcdataupdate.cpp b/src/core/fsd/atcdataupdate.cpp
@@ -11,8 +11,6 @@ using namespace swift::misc::network;
 
 namespace swift::core::fsd
 {
-    AtcDataUpdate::AtcDataUpdate() : MessageBase() {}
-
     AtcDataUpdate::AtcDataUpdate(const QString &sender, int frequencykHz, CFacilityType facility, int visibleRange,
                                  AtcRating rating, double latitude, double longitude, int elevation)
         : MessageBase(sender, {}), m_frequencykHz(frequencykHz), m_facility(facility), m_visibleRange(visibleRange),
diff --git a/src/core/fsd/atcdataupdate.h b/src/core/fsd/atcdataupdate.h
@@ -46,7 +46,7 @@ namespace swift::core::fsd
 
     private:
         //! Ctor
-        AtcDataUpdate();
+        AtcDataUpdate() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/authchallenge.cpp b/src/core/fsd/authchallenge.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    AuthChallenge::AuthChallenge() : MessageBase() {}
-
     AuthChallenge::AuthChallenge(const QString &sender, const QString &target, const QString &challengeKey)
         : MessageBase(sender, target), m_challengeKey(challengeKey)
     {}
diff --git a/src/core/fsd/authchallenge.h b/src/core/fsd/authchallenge.h
@@ -30,7 +30,7 @@ namespace swift::core::fsd
 
     private:
         //! Ctor
-        AuthChallenge();
+        AuthChallenge() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/authresponse.cpp b/src/core/fsd/authresponse.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    AuthResponse::AuthResponse() : MessageBase() {}
-
     AuthResponse::AuthResponse(const QString &sender, const QString &receiver, const QString &response)
         : MessageBase(sender, receiver), m_response(response)
     {}
diff --git a/src/core/fsd/authresponse.h b/src/core/fsd/authresponse.h
@@ -30,7 +30,7 @@ namespace swift::core::fsd
         QString m_response; //!< response
 
     private:
-        AuthResponse();
+        AuthResponse() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/clientidentification.cpp b/src/core/fsd/clientidentification.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    ClientIdentification::ClientIdentification() : MessageBase() {}
-
     ClientIdentification::ClientIdentification(const QString &sender, quint16 clientId, const QString &clientName,
                                                int clientVersionMajor, int clientVersionMinor, const QString &userCid,
                                                const QString &sysUid, const QString &initialChallenge)
diff --git a/src/core/fsd/clientidentification.h b/src/core/fsd/clientidentification.h
@@ -43,7 +43,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        ClientIdentification();
+        ClientIdentification() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/clientquery.cpp b/src/core/fsd/clientquery.cpp
@@ -8,8 +8,6 @@
 
 namespace swift::core::fsd
 {
-    ClientQuery::ClientQuery() : MessageBase() {}
-
     ClientQuery::ClientQuery(const QString &sender, const QString &clientToBeQueried, ClientQueryType queryType,
                              const QStringList &queryData)
         : MessageBase(sender, clientToBeQueried), m_queryType(queryType), m_queryData(queryData)
diff --git a/src/core/fsd/clientquery.h b/src/core/fsd/clientquery.h
@@ -40,7 +40,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        ClientQuery();
+        ClientQuery() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/deleteatc.cpp b/src/core/fsd/deleteatc.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    DeleteAtc::DeleteAtc() : MessageBase() {}
-
     DeleteAtc::DeleteAtc(const QString &sender, const QString &cid) : MessageBase(sender), m_cid(cid) {}
 
     QStringList DeleteAtc::toTokens() const
diff --git a/src/core/fsd/deleteatc.h b/src/core/fsd/deleteatc.h
@@ -29,7 +29,7 @@ namespace swift::core::fsd
         QString m_cid; //!< id
 
     private:
-        DeleteAtc();
+        DeleteAtc() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/deletepilot.cpp b/src/core/fsd/deletepilot.cpp
@@ -9,8 +9,6 @@ using namespace swift::misc;
 
 namespace swift::core::fsd
 {
-    DeletePilot::DeletePilot() : MessageBase() {}
-
     DeletePilot::DeletePilot(const QString &callsign, const QString &id) : MessageBase(callsign), m_cid(id) {}
 
     QStringList DeletePilot::toTokens() const
diff --git a/src/core/fsd/deletepilot.h b/src/core/fsd/deletepilot.h
@@ -31,7 +31,7 @@ namespace swift::core::fsd
 
     private:
         //! Ctor
-        DeletePilot();
+        DeletePilot() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/fsdidentification.cpp b/src/core/fsd/fsdidentification.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    FSDIdentification::FSDIdentification() : MessageBase() {}
-
     FSDIdentification::FSDIdentification(const QString &callsign, const QString &receiver, const QString &serverVersion,
                                          const QString &initialChallenge)
         : MessageBase(callsign, receiver), m_serverVersion(serverVersion), m_initialChallenge(initialChallenge)
diff --git a/src/core/fsd/fsdidentification.h b/src/core/fsd/fsdidentification.h
@@ -34,7 +34,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        FSDIdentification();
+        FSDIdentification() = default;
     };
 } // namespace swift::core::fsd
 
diff --git a/src/core/fsd/interimpilotdataupdate.cpp b/src/core/fsd/interimpilotdataupdate.cpp
@@ -8,8 +8,6 @@
 
 namespace swift::core::fsd
 {
-    InterimPilotDataUpdate::InterimPilotDataUpdate() : MessageBase() {}
-
     InterimPilotDataUpdate::InterimPilotDataUpdate(const QString &sender, const QString &receiver, double latitude,
                                                    double longitude, int altitudeTrue, int groundSpeed, double pitch,
                                                    double bank, double heading, bool onGround)
diff --git a/src/core/fsd/interimpilotdataupdate.h b/src/core/fsd/interimpilotdataupdate.h
@@ -42,7 +42,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        InterimPilotDataUpdate();
+        InterimPilotDataUpdate() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/killrequest.cpp b/src/core/fsd/killrequest.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    KillRequest::KillRequest() : MessageBase() {}
-
     KillRequest::KillRequest(const QString &callsign, const QString &receiver, const QString &reason)
         : MessageBase(callsign, receiver), m_reason(reason)
     {}
diff --git a/src/core/fsd/killrequest.h b/src/core/fsd/killrequest.h
@@ -30,7 +30,7 @@ namespace swift::core::fsd
         QString m_reason; //!< reason for kill request/kicked
 
     private:
-        KillRequest();
+        KillRequest() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/pilotdataupdate.cpp b/src/core/fsd/pilotdataupdate.cpp
@@ -12,8 +12,6 @@ using namespace swift::misc::aviation;
 
 namespace swift::core::fsd
 {
-    PilotDataUpdate::PilotDataUpdate() : MessageBase() {}
-
     PilotDataUpdate::PilotDataUpdate(CTransponder::TransponderMode transponderMode, const QString &sender,
                                      int transponderCode, PilotRating rating, double latitude, double longitude,
                                      int altitudeTrue, int altitudePressure, int groundSpeed, double pitch, double bank,
diff --git a/src/core/fsd/pilotdataupdate.h b/src/core/fsd/pilotdataupdate.h
@@ -49,7 +49,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        PilotDataUpdate();
+        PilotDataUpdate() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/ping.cpp b/src/core/fsd/ping.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    Ping::Ping() : MessageBase() {}
-
     Ping::Ping(const QString &sender, const QString &receiver, const QString &timestamp)
         : MessageBase(sender, receiver), m_timestamp(timestamp)
     {}
diff --git a/src/core/fsd/ping.h b/src/core/fsd/ping.h
@@ -29,7 +29,7 @@ namespace swift::core::fsd
         QString m_timestamp; //!< timestamp
 
     private:
-        Ping();
+        Ping() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/planeinforequest.cpp b/src/core/fsd/planeinforequest.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    PlaneInfoRequest::PlaneInfoRequest() : MessageBase() {}
-
     PlaneInfoRequest::PlaneInfoRequest(const QString &sender, const QString &receiver) : MessageBase(sender, receiver)
     {}
 
diff --git a/src/core/fsd/planeinforequest.h b/src/core/fsd/planeinforequest.h
@@ -28,7 +28,7 @@ namespace swift::core::fsd
         static QString pdu() { return QStringLiteral("#SB"); }
 
     private:
-        PlaneInfoRequest();
+        PlaneInfoRequest() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/planeinforequestfsinn.cpp b/src/core/fsd/planeinforequestfsinn.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    PlaneInfoRequestFsinn::PlaneInfoRequestFsinn() : MessageBase() {}
-
     PlaneInfoRequestFsinn::PlaneInfoRequestFsinn(const QString &sender, const QString &receiver,
                                                  const QString &airlineIcao, const QString &aircraftIcao,
                                                  const QString &aircraftIcaoCombinedType,
diff --git a/src/core/fsd/planeinforequestfsinn.h b/src/core/fsd/planeinforequestfsinn.h
@@ -37,7 +37,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        PlaneInfoRequestFsinn();
+        PlaneInfoRequestFsinn() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/planeinformation.cpp b/src/core/fsd/planeinformation.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    PlaneInformation::PlaneInformation() : MessageBase() {}
-
     PlaneInformation::PlaneInformation(const QString &sender, const QString &receiver, const QString &aircraft,
                                        const QString &airline = QString(), const QString &livery = QString())
         : MessageBase(sender, receiver), m_aircraft(aircraft), m_airline(airline), m_livery(livery)
diff --git a/src/core/fsd/planeinformation.h b/src/core/fsd/planeinformation.h
@@ -36,7 +36,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        PlaneInformation();
+        PlaneInformation() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/planeinformationfsinn.cpp b/src/core/fsd/planeinformationfsinn.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    PlaneInformationFsinn::PlaneInformationFsinn() : MessageBase() {}
-
     PlaneInformationFsinn::PlaneInformationFsinn(const QString &sender, const QString &receiver,
                                                  const QString &airlineIcao, const QString &aircraftIcao,
                                                  const QString &aircraftIcaoCombinedType,
diff --git a/src/core/fsd/planeinformationfsinn.h b/src/core/fsd/planeinformationfsinn.h
@@ -37,7 +37,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        PlaneInformationFsinn();
+        PlaneInformationFsinn() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/pong.cpp b/src/core/fsd/pong.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    Pong::Pong() : MessageBase() {}
-
     Pong::Pong(const QString &sender, const QString &receiver, const QString &timestamp)
         : MessageBase(sender, receiver), m_timestamp(timestamp)
     {}
diff --git a/src/core/fsd/pong.h b/src/core/fsd/pong.h
@@ -29,7 +29,7 @@ namespace swift::core::fsd
         QString m_timestamp; //!< timestamp
 
     private:
-        Pong();
+        Pong() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/rehost.cpp b/src/core/fsd/rehost.cpp
@@ -12,8 +12,6 @@ using namespace swift::misc::aviation;
 
 namespace swift::core::fsd
 {
-    Rehost::Rehost() : MessageBase() {}
-
     Rehost::Rehost(const QString &sender, const QString &hostname) : MessageBase(sender, {}), m_hostname(hostname) {}
 
     QStringList Rehost::toTokens() const { return { m_sender, m_hostname }; }
diff --git a/src/core/fsd/rehost.h b/src/core/fsd/rehost.h
@@ -33,7 +33,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        Rehost();
+        Rehost() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/textmessage.cpp b/src/core/fsd/textmessage.cpp
@@ -7,8 +7,6 @@
 
 namespace swift::core::fsd
 {
-    TextMessage::TextMessage() : MessageBase() {}
-
     TextMessage::TextMessage(const QString &sender, const QString &receiver, const QString &message)
         : MessageBase(sender, receiver), m_message(message)
     {
diff --git a/src/core/fsd/textmessage.h b/src/core/fsd/textmessage.h
@@ -42,7 +42,7 @@ namespace swift::core::fsd
         QVector<int> m_frequencies; //!< frequencies in case of radio message.
 
     private:
-        TextMessage();
+        TextMessage() = default;
     };
 } // namespace swift::core::fsd
 
diff --git a/src/core/fsd/visualpilotdataperiodic.cpp b/src/core/fsd/visualpilotdataperiodic.cpp
@@ -14,8 +14,6 @@ using namespace swift::misc::aviation;
 
 namespace swift::core::fsd
 {
-    VisualPilotDataPeriodic::VisualPilotDataPeriodic() : MessageBase() {}
-
     VisualPilotDataPeriodic::VisualPilotDataPeriodic(const QString &sender, double latitude, double longitude,
                                                      double altitudeTrue, double heightAgl, double pitch, double bank,
                                                      double heading, double xVelocity, double yVelocity,
diff --git a/src/core/fsd/visualpilotdataperiodic.h b/src/core/fsd/visualpilotdataperiodic.h
@@ -54,7 +54,7 @@ namespace swift::core::fsd
         //! @}
 
     private:
-        VisualPilotDataPeriodic();
+        VisualPilotDataPeriodic() = default;
     };
 
     //! Equal to operator
diff --git a/src/core/fsd/visualpilotdatastopped.cpp b/src/core/fsd/visualpilotdatastopped.cpp
diff --git a/src/core/fsd/visualpilotdatastopped.h b/src/core/fsd/visualpilotdatastopped.h
diff --git a/src/core/fsd/visualpilotdatatoggle.cpp b/src/core/fsd/visualpilotdatatoggle.cpp
diff --git a/src/core/fsd/visualpilotdatatoggle.h b/src/core/fsd/visualpilotdatatoggle.h
diff --git a/src/core/fsd/visualpilotdataupdate.cpp b/src/core/fsd/visualpilotdataupdate.cpp
diff --git a/src/core/fsd/visualpilotdataupdate.h b/src/core/fsd/visualpilotdataupdate.h
diff --git a/src/core/simulator.cpp b/src/core/simulator.cpp
diff --git a/src/gui/components/simulatorcomponent.cpp b/src/gui/components/simulatorcomponent.cpp
diff --git a/src/gui/components/usercomponent.cpp b/src/gui/components/usercomponent.cpp
diff --git a/src/misc/network/urllog.cpp b/src/misc/network/urllog.cpp
diff --git a/src/misc/simulation/remoteaircraftprovider.cpp b/src/misc/simulation/remoteaircraftprovider.cpp

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,6 @@`
`8`	`8`
`9`	`9`	`namespace swift::core::fsd`
`10`	`10`	`{`
`11`		`- AddAtc::AddAtc() : MessageBase() {}`
`12`		`-`
`13`	`11`	`AddAtc::AddAtc(const QString &callsign, const QString &realName, const QString &cid, const QString &password,`
`14`	`12`	`AtcRating rating, int protocolRevision)`
`15`	`13`	`: MessageBase(callsign, "SERVER"), m_cid(cid), m_password(password), m_rating(rating),`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@ using namespace swift::misc::network;`
`11`	`11`
`12`	`12`	`namespace swift::core::fsd`
`13`	`13`	`{`
`14`		`- AtcDataUpdate::AtcDataUpdate() : MessageBase() {}`
`15`		`-`
`16`	`14`	`AtcDataUpdate::AtcDataUpdate(const QString &sender, int frequencykHz, CFacilityType facility, int visibleRange,`
`17`	`15`	`AtcRating rating, double latitude, double longitude, int elevation)`
`18`	`16`	`: MessageBase(sender, {}), m_frequencykHz(frequencykHz), m_facility(facility), m_visibleRange(visibleRange),`
Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,6 @@`
`7`	`7`
`8`	`8`	`namespace swift::core::fsd`
`9`	`9`	`{`
`10`		`- AuthChallenge::AuthChallenge() : MessageBase() {}`
`11`		`-`
`12`	`10`	`AuthChallenge::AuthChallenge(const QString &sender, const QString &target, const QString &challengeKey)`
`13`	`11`	`: MessageBase(sender, target), m_challengeKey(challengeKey)`
`14`	`12`	`{}`