Add support for arrays > 32 in Rust [GV2-74] #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming ed25519 signature message requires a fixed array of size 64 which currently breaks the Rust build because Serde does not currently natively support serializing or deserialzing arrays with sizes larger than 32. The `serde-big-array` crates allows us to work around this issue by using macros defined there for larger arrays.
silverjam
approved these changes
Jun 27, 2022
samvrlewis
added a commit
that referenced
this pull request
Jul 6, 2022
The upcoming ed25519 signature message requires a fixed array of size 64 which currently breaks the Rust build because Serde does not currently natively support serializing or deserialzing arrays with sizes larger than 32. The `serde-big-array` crates allows us to work around this issue by using macros defined there for larger arrays.
samvrlewis
added a commit
that referenced
this pull request
Jul 6, 2022
The upcoming ed25519 signature message requires a fixed array of size 64 which currently breaks the Rust build because Serde does not currently natively support serializing or deserialzing arrays with sizes larger than 32. The `serde-big-array` crates allows us to work around this issue by using macros defined there for larger arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The upcoming ed25519 signature message requires a fixed array of size 64
which currently breaks the Rust build because Serde does not currently
natively support serializing or deserialzing arrays with sizes larger
than 32.
The
serde-big-arraycrates allows us to work around this issue byusing macros defined there for larger arrays.
API compatibility
No, it only allows bigger arrays to be serialized to JSON.
JIRA Reference
https://swift-nav.atlassian.net/browse/GV2-74