Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented May 25, 2022

Description

@swift-nav/devinfra

Previous docker image removed apt and a number of other things that are useful for debugging the image after the image has been built, so add these back.

In the interest of simplicity, only support focal for the build container. The purpose of the build container is to provide a consistent build environment for generating bindings, not to provide a build recipe for a bunch of different Ubuntu releases.

Removes unused Docker build files, these haven't been used for a while.

API compatibility

Does this change introduce a API compatibility risk? No.

JIRA Reference

https://swift-nav.atlassian.net/browse/DEVINFRA-771

@silverjam silverjam changed the title docker: stop removing apt docker: stop removing apt, only support Ubuntu focal May 25, 2022
@silverjam silverjam changed the title docker: stop removing apt, only support Ubuntu focal docker: add apt, focal only, tox fixes May 26, 2022
@silverjam silverjam marked this pull request as ready for review May 26, 2022 06:19
@silverjam silverjam requested a review from a team as a code owner May 26, 2022 06:19
@silverjam silverjam changed the title docker: add apt, focal only, tox fixes docker: add back apt, focal only, tox fixes May 26, 2022
Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for removing apt to begin with? Save size?

@silverjam
Copy link
Contributor Author

What was the reason for removing apt to begin with? Save size?

Possibly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants