Skip to content

Conversation

char0n
Copy link
Contributor

@char0n char0n commented Nov 4, 2021

Closes #7525

Description

buildUrl function used for URL resolution throws error on certain conditions. These conditions includes resolving against Server.url containing ServerVariable/s: https://api.example.com:{port}/{basePath}`

Safe version of buildUrl called safeBuildUrl has been created to swallow the URL resolution error and allow React rendering to continue uninterrupted.

How Has This Been Tested?

New tests have been added.

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n self-assigned this Nov 4, 2021
@char0n char0n merged commit fb7e98a into master Nov 4, 2021
@char0n char0n deleted the char0n/server-url-variables branch March 8, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwaggerUI throws an error when changing Servers
1 participant