Skip to content

improvement: showCommonExtensions support for OAS3 parameters #5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2020
Merged

improvement: showCommonExtensions support for OAS3 parameters #5901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd1dedd
ref #5016 - showCommonExtensions support for OAS3 parameters
hkosova Mar 5, 2020
1e3c931
Merge branch 'master' into ft/5016-oas3-showCommonExtensions
shockey Mar 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/components/parameter-row.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export default class ParameterRow extends Component {
let itemType = schema.getIn(["items", "type"])

let value = paramWithMeta ? paramWithMeta.get("value") : ""
let commonExt = showCommonExtensions ? getCommonExtensions(param) : null
let commonExt = showCommonExtensions ? getCommonExtensions(schema) : null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great reuse of our existing version-specific logic!

let extensions = showExtensions ? getExtensions(param) : null

let paramItems // undefined
Expand Down