Basic auth: Support empty passwords #1497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't cast non-string passwords to string (e.g. undefined to "undefined").
I'm not sure if
value.password instanceof String
is needed or if a test for plain strings would be sufficient. Or should it explicitly test forundefined
? Because people expect whatever they pass to be converted to string implicitly, except the blank password case?Should the username also be checked?
Motivation and Context
Empty passwords for basic HTTP authorization is a valid use case (see swagger-api/swagger-ui#5410) and I opened a PR to allow this in the frontend (swagger-api/swagger-ui#5812), but it turned out that the swagger-client casts the undefined
password
to a string, leading to an incorrect base64-encoded password."root:undefined"
→"cm9vdDp1bmRlZmluZWQ="
❌"root:"
→"cm9vdDo="
✔How Has This Been Tested?
Types of changes
package.json
)Checklist:
and existingtests passed.