Skip to content

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Jul 25, 2022

Description

  • add a dev comment expanding on the FSA acronym
  • rename the ParseErrors directory, to not include the typo

Motivation and Context

  • easier future reference of the FSA acronym

followup to #3241

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai changed the title Refactor/next state cleanup refactor: minor cleanup Jul 25, 2022
@tim-lai tim-lai merged commit 2b20787 into next Jul 25, 2022
@swagger-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tim-lai tim-lai deleted the refactor/next-state-cleanup branch July 29, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants