fix: use arraySchema when deciding required of an array #4998
+182
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewaostrowska
force-pushed
the
bug/4341-fix-required-mode-array-schema
branch
from
cca635e to
3edb10d
Compare
ewaostrowska
force-pushed
the
bug/4341-fix-required-mode-array-schema
branch
from
3edb10d to
9c13612
Compare
ewaostrowska
approved these changes
Nov 24, 2025
Contributor
|
@keigo-brook thank you for taking care of this issue. I have added an additional test to prove that it works for other properties as well. Otherwise looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Fixes: #4341
Type of Change
Checklist
Screenshots / Additional Context