Feature/deep linking #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow for deep linking, and generally make the navigation more more flexible, we need to use the new navigation system Router (Navigator 2.0) This commit emulates the behavior of the old router. Instead of ``` Navigator.push( context, MaterialPageRoute(...), ); ``` we can now use ``` MyRouterDelegate.of(context).push(MyPage(child: ...)); ```
Update packages so we can use flutter 2.0. This seems to fix deep linking with Router. Currently, with flutter 2.0.1, deep linking does not work on android. It couses a crash, as described in flutter/flutter#75261. The fix to this issue has been merged, but apparantly it's not included in the release 2.0.1. The deep links are now only with custom scheme "thaliapp://". For universal links (https), we need to work with the website.
This was referenced Mar 7, 2021
Member
Author
|
Deeplinking works now, on the flutter master channel. On android, Dee-links cause a crash if on the stable channel. This is fixed in flutter/engine#24146, which is apparently not included in the 2.0.1 stable branch: It is included in master: To switch to the master channel, run |
Member
Author
|
Btw, currently deep linking works for |
KiOui
approved these changes
Mar 15, 2021
Rename routerDelegate and routInformationParser Check for login in routerDelegate, deprecating SplashScreen. If a link is opened while logged out, the stack is replaced with a login screen, so the link is lost. No other page can be opened while logged out. Fix deep link patterns Switch deep link schemes to https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to Router/Navigator 2.0 to support Deep Linking.
Add deep linking configuration for 'thaliapp://thalia.nu/' and 'https://thalia.nu/' links.
This should work, but somehow it does not. Deep Links open the app, but the url is
not actually being parsed by the RouteInformationParser. The parser is only called
with "/" upon starting the app.
The deep linking has to be fixed.
After that the routerDelegate should be improved a bit, as described by TODO comments.
Closes #22