Skip to content

Fail test execution if there were duplicate test names (#106) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Fail test execution if there were duplicate test names (#106) #107

merged 1 commit into from
Apr 20, 2020

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Apr 20, 2020 •
edited
Loading

fixes #106

@Vampire
Copy link
Contributor Author

Vampire commented Apr 20, 2020

There is no need to tag a new version for this pr :-)

hartwork
hartwork approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy! Thanks for the quick reaction. Looks good to me! 👍 @tnyblom any concerns?

@tnyblom tnyblom merged commit ece0088 into svn-all-fast-export:master Apr 20, 2020
@Vampire Vampire deleted the fail-on-duplicate-test-name branch April 20, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartwork hartwork hartwork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test name collision
3 participants
@Vampire @hartwork @tnyblom