Skip to content

[@svelteui/core]: Fix - Disabled tabs can still be accessed using left and right keys #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[@svelteui/core]: Fix - Disabled tabs can still be accessed using left and right keys #469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4954c2a
fixed disabled tab issue
TMuthu Sep 29, 2023
b5e2b1b
Merge branch 'main' into main
TMuthu Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/svelteui-core/src/components/Tabs/Tabs.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,27 @@
let _index = _active;
if (event.code === nextTabCode) {
if (_index + 1 >= tabs.length) return;
_index += 1;
let current = _index + 1;
let end = tabs.length - 1;
while (current <= end)
if (tabs[current] && tabs[current]['disabled']) current++;
else break;
if (current > end) return;
_index = current;
} else if (event.code === previousTabCode) {
if (_index - 1 < 0) return;
_index -= 1;
let current = _index - 1;
let end = 0;
while (current >= end)
if (tabs[current] && tabs[current]['disabled']) current--;
else break;
if (current < end) return;
_index = current;
}

event.preventDefault();
const selectedTab = Array.from(tabs)[_index];
if (selectedTab) selectedTab['focus']();
const selectedKey = selectedTab.getAttribute('data-key');

dispatch('change', { index: _index, key: selectedKey });
Expand Down