Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

Conversation

jacwright
Copy link
Contributor

No description provided.

@jacwright
Copy link
Contributor Author

Fixes #350

@Conduitry
Copy link
Member

Thanks for writing some docs to go along with your new feature! I've added a few comments about things I think should be tweaked.

@Cweili
Copy link

Cweili commented Oct 24, 2018

@jacwright

#371

The demo of the shorthand of class binding has "Error compiling component".

Link:

https://svelte.technology/repl?version=2.14.2&demo=bz2ba6

Error:

Computed property name 'is-selected' is invalid — must be a valid identifier such as is_selected
12:     // Because shorthand relfects the var name, you must use component.set({ "is-selected": true }) or use a computed
13:     // property like this. It might be better to avoid shorthand for class names which are not valid variable names.
14:     "is-selected": ({ isSelected }) => isSelected
        ^
15:   }
16: }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants