Skip to content

chore: move playground #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benmccann merged 3 commits into from
Aug 22, 2023
Merged

chore: move playground #9131

benmccann merged 3 commits into from
Aug 22, 2023

Conversation

@benmccann
Copy link
Member

@benmccann benmccann commented Aug 21, 2023

Match the directory structure we're using in the kit and Svelte 5 code bases

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b1c182c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gtm-nayan
gtm-nayan reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@gtm-nayan gtm-nayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm-workspace.yaml and lockfile needs to be updated as well

@TKDev7
Copy link

TKDev7 commented Aug 22, 2023

Where is the svelte 5 codebase at :D ?

@benmccann
Copy link
Member Author

benmccann commented Aug 22, 2023

Not ready to share yet 😉 Just experimenting for now

@benmccann benmccann requested a review from gtm-nayan August 22, 2023 15:24
@benmccann benmccann merged commit 3d3680c into master Aug 22, 2023
@benmccann benmccann deleted the playground branch August 22, 2023 22:00
@noy4
Copy link

noy4 commented Aug 24, 2023

(report)
playground dev command fails.
I think svelte paths in playgrounds/basic/start.js needs to be updated

@benmccann
Copy link
Member Author

benmccann commented Aug 24, 2023

thanks. sent a PR here: #9139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gtm-nayan gtm-nayan gtm-nayan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benmccann @TKDev7 @noy4 @gtm-nayan