-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[fix] Removal of empty stylesheets created from transitions #7260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MathiasWP
wants to merge
6
commits into
sveltejs:master
from
MathiasWP:style_manager-stylesheet-cleanup
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
37dfcad
Updated style_manager cleanup to remove created stylesheets instead o…
MathiasWP 5def8c7
Linted files
MathiasWP b00cadf
Fixed test
MathiasWP 8f7b155
Removed return type declaration
MathiasWP 02bc49b
Update src/runtime/internal/dom.ts
MathiasWP 662faa3
Update test/runtime/samples/style_manager-cleanup/_config.js
MathiasWP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
export default { | ||
skip_if_ssr: true, | ||
skip_if_hydrate: true, | ||
skip_if_hydrate_from_ssr: true, | ||
tanhauhau marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
async test({ raf, assert, component, window }) { | ||
component.visible = true; | ||
raf.tick(100); | ||
component.visible = false; | ||
raf.tick(200); | ||
raf.tick(0); | ||
|
||
assert.htmlEqual( | ||
window.document.head.innerHTML, | ||
'' | ||
); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<script> | ||
export let visible = false; | ||
|
||
function foo(node, params) { | ||
return { | ||
duration: 100, | ||
css: () => '' | ||
}; | ||
} | ||
</script> | ||
|
||
{#if visible} | ||
<div transition:foo></div> | ||
{/if} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also be removed