Fixed issue 5475 #5536
Merged
Fixed issue 5475 #5536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@damianpumar - thanks a ton for fixing this - eager to try it. Any idea on a patch release to push this out? |
antony
approved these changes
Oct 20, 2020
hontas
added a commit
to hontas/svelte
that referenced
this pull request
Oct 29, 2020
* upstream/master: (140 commits) support $$props and $$restProps for custom elements (sveltejs#5608) Bump eslint-config to 5.5.0 (sveltejs#5599) update changelog add Node and Element as known globals (sveltejs#5601) docs: fix a11y warning in media elements example (sveltejs#5606) Curly braces linting fixes (sveltejs#5585) refactor sourcemap and preprocessor tests (sveltejs#5583) -> v3.29.4 fix code generation error with nullish coalescing operator and logical operators (sveltejs#5564) -> v3.29.3 -> v3.29.2 -> v3.29.1 docs: fix a11y warning in media elements tutorial (sveltejs#5523) update changelog get context at start of {#if} update block instead of at the end (sveltejs#5531) update changelog only allow passing functions to lifecycle functions (sveltejs#5529) update changelog fix compiler hanging on <slot slot="..."> (sveltejs#5536) Add svelte@next caveat to bug report template (sveltejs#5561) ...
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #5475 but is related to recently opened issue #5535
The problem behind this was the create_debugging_comment function never finished in this case, for this reason the compiler never finished.