spread condition for input element #5004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4418
When updating input.value, we check whether
input.value === value
before setting it:however we didnt check this when using spread:
this MR tries to fix this
I did some moving code around, so i can extract the logic from Attribute#render that handles the special case for
input.value
,input.src
,should_cache
, etc, still figuring out what's the best way to refactor them, suggestions welcome.Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)